refactor(datepicker): remove focus from clear button #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/kv06akbl0 |
Codecov Report
@@ Coverage Diff @@
## beta #524 +/- ##
==========================================
+ Coverage 95.02% 95.37% +0.34%
==========================================
Files 16 16
Lines 523 519 -4
Branches 100 99 -1
==========================================
- Hits 497 495 -2
+ Misses 26 24 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor. Related to this comment.
What is the current behavior?
When the input is focused, the content is selected. When the user presses
Tab, we focus the clear button.What is the new behavior?
Focus the clear button is a bit unnecessary since the content is selected every time the input is focused, allowing the user to clear it by pressing
BackspaceorDelete.Checklist: